Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUNTIME] Remove Extension VTable in favor of Unified Object system. #4578

Merged
merged 1 commit into from
Dec 25, 2019
Merged

[RUNTIME] Remove Extension VTable in favor of Unified Object system. #4578

merged 1 commit into from
Dec 25, 2019

Commits on Dec 24, 2019

  1. [RUNTIME] Remove Extension VTable in favor of Unified Object system. 

    Before the unified object protocol, we support pass
additional extension objects around by declaring a type as an extension type.
The old extension mechanism requires the types to register their
constructor and deleter to a VTable and does not enjoy the benefit of the
self-contained deletion property of the new Object system.

This PR upgrades the extension example to make use of the new object system
and removed the old Extension VTable.

Note that the register_extension funtion in the python side continues to work
when the passed argument does not require explicit container copy/deletion,
which covers the current usecases of the extension mechanism.
    @tqchen
    tqchen committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    5e3f251 View commit details
    Browse the repository at this point in the history