[CONV3D] remove incorrect schedule for conv3d_ndhwc #4659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
added
status: need test case
optima2005
force-pushed
the
fix_conv3d_ndhwc
branch
from
02453a9
to
6c9345d
Compare
|
if you remove schedule_conv3d_ndhwc_cuda, what happens if schedule_conv3d_ndhwc was called on cuda target? You get an error? |
|
Never mind. I'll fix the conv3d issue in #4644 since I'm changing the TOPI. |
|
@masahi Yes. it would report error. Currently at least in TF frontend, the NHWC for conv2d, NDHWC for conv3d are forced to transform to NCHW/NCDHW layout. Please see this, this and this. I guess that might be under perormance consideration. But a more user friendly approach may be needed to notice the user TVM not supporting those layouts under cuda target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #4604, to remove unnecessary and incorrect cuda schedule for conv3d_ndhwc
@masahi @icemelon9