Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ==/!= to compare str, bytes, and int literals #4686

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Use ==/!= to compare str, bytes, and int literals #4686

merged 1 commit into from
Jan 11, 2020

Commits on Jan 11, 2020

  1. Use ==/!= to compare str, bytes, and int literals 

    Identity is not the same thing as equality in Python so use ==/!= to compare str, bytes, and int literals. In Python >= 3.8, these instances will raise __SyntaxWarnings__ so it is best to fix them now. https://docs.python.org/3.8/whatsnew/3.8.html#porting-to-python-3-8

% __python__
```
>>> dtype = "float"
>>> dtype += "16"
>>> dtype == "float16"
True
>>> dtype is "float16"
False
>>> 0 == 0.0
True
>>> 0 is 0.0
False
```
    @cclauss
    cclauss authored Jan 11, 2020
    Configuration menu
    Copy the full SHA
    778cb79 View commit details
    Browse the repository at this point in the history