[Bugfix] Fixed crash caused by reversing bitwise operations #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c python type was on the left hand side of the expression. Added regression test for crashing cases.
dpankratz
changed the title
dpankratz
changed the title
tqchen
approved these changes
Feb 10, 2020
tqchen
added
status: need test case
|
Thanks @dpankratz ! |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…c python type was on the left hand side of the expression. Added regression test for crashing cases. (apache#4852)
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…c python type was on the left hand side of the expression. Added regression test for crashing cases. (apache#4852)
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…c python type was on the left hand side of the expression. Added regression test for crashing cases. (apache#4852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug when using the bitwise operators bitwise_xor, bitwise_and, and bitwise_or.
The following code results in a Python TypeError:
For reference this code is accepted:
Analogous crashes occur for the case of
10 | aand10 & a.This pull requests fixes this crash for the operators bitwise_xor, bitwise_and, and bitwise_or. It also adds a regression test.
cc @tqchen @inadob @ZihengJiang