Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tutorial] Add a tutorial for PyTorch #4936

Merged
merged 8 commits into from
Feb 26, 2020
Merged

[Tutorial] Add a tutorial for PyTorch #4936

merged 8 commits into from
Feb 26, 2020

Conversation

alexwong
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Wasn't sure if a tutorial is expected for new frontends but I wrote one a while ago and now #4497 is merged.

@alexwong alexwong changed the title Add a tutorial for PyTorch [Tutorial] Add a tutorial for PyTorch Feb 25, 2020
comaniac
comaniac requested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the comments to fix the Sphinx format issues.

tutorials/frontend/from_pytorch.py Outdated Show resolved Hide resolved
tutorials/frontend/from_pytorch.py Outdated Show resolved Hide resolved
tutorials/frontend/from_pytorch.py Outdated Show resolved Hide resolved
zhiics
zhiics reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masahi please help take a look as well. Thanks.

comaniac
comaniac approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi self-assigned this Feb 26, 2020
@masahi masahi merged commit 61bea50 into apache:master Feb 26, 2020
@masahi
Copy link
Member

masahi commented Feb 26, 2020

Thanks @alexwong @zhiics @comaniac @kevinthesun @yzhliu

alexwong added a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@alexwong
[Tutorial] Add a tutorial for PyTorch (apache#4936)
9f87e31 
* Add a tutorial for PyTorch

* Fix sphinx formatting, add version support

* Remove space

* Remove version check

* Some refactoring

* Use no grad

* Rename input

* Update cat img source
alexwong added a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@alexwong
[Tutorial] Add a tutorial for PyTorch (apache#4936)
6d6638e 
* Add a tutorial for PyTorch

* Fix sphinx formatting, add version support

* Remove space

* Remove version check

* Some refactoring

* Use no grad

* Rename input

* Update cat img source
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@alexwong @zhiics
[Tutorial] Add a tutorial for PyTorch (apache#4936)
3bb793b 
* Add a tutorial for PyTorch

* Fix sphinx formatting, add version support

* Remove space

* Remove version check

* Some refactoring

* Use no grad

* Rename input

* Update cat img source
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhliu yzhliu yzhliu left review comments

@zhiics zhiics zhiics left review comments

@kevinthesun kevinthesun kevinthesun left review comments

@masahi masahi masahi approved these changes

@comaniac comaniac comaniac approved these changes

Assignees

@masahi masahi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwong @masahi @yzhliu @zhiics @comaniac @kevinthesun