Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Docker] pin xgboost dependency version to 0.90 #4965

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[CI][Docker] pin xgboost dependency version to 0.90 #4965

merged 1 commit into from
Mar 3, 2020

Conversation

leandron
Copy link
Contributor

Pin xgboost dependency version to 0.90

cc @tqchen

@leandron
Copy link
Contributor Author

It seems the broken build reason is not specifically related to this patch.

@masahi
Copy link
Member

masahi commented Feb 28, 2020

hey @leandron we are in the same boat. The discussion is happening at #4961 (comment)

@leandron
Copy link
Contributor Author

hey @leandron we are in the same boat. The discussion is happening at #4961 (comment)

Thanks @masahi, I posted my comments there.

@tqchen
Copy link
Member

tqchen commented Feb 28, 2020

the fix #4967 has been merged, please send another commit to retrigger the CI

@leandron leandron closed this Feb 29, 2020
@leandron leandron reopened this Feb 29, 2020
@tqchen
Copy link
Member

tqchen commented Mar 1, 2020

Reopen won't trigger the case, need a dummy commit

@cchung100m
Copy link
Contributor

@leandron

Please use the command below to submit a dummy commit, thanks.

git commit --allow-empty -m "Trigger CI"

@masahi
Copy link
Member

masahi commented Mar 2, 2020

no need to do dummy commit, just fetch and rebase against master

 * Sets xgboost dependency to be 0.90, preventing
   segfaults during TVM python unit tests execution

 * This is discussed in issue #4953
@leandron
Copy link
Contributor Author

leandron commented Mar 2, 2020

Thanks @masahi @cchung100m @tqchen

@tqchen tqchen merged commit 09ddc3e into apache:master Mar 3, 2020
@tqchen
Copy link
Member

tqchen commented Mar 3, 2020

Thanks @leandron this is merged.

it would be great if you and @hcho3 can followup on #4953 given that we have quite a bit of overlap between the two communities, we want to make sure the latest XGBoost and TVM works together

@leandron
Copy link
Contributor Author

leandron commented Mar 4, 2020

Thanks @tqchen. I'll see to provide @hcho3 with instruction on how to reproduce the issue I see on xgboost.

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
* Sets xgboost dependency to be 0.90, preventing
   segfaults during TVM python unit tests execution

 * This is discussed in issue apache#4953
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
* Sets xgboost dependency to be 0.90, preventing
   segfaults during TVM python unit tests execution

 * This is discussed in issue apache#4953
@leandron leandron deleted the tvm-pin_xgboost_version branch August 12, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants