-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction #5019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for looking into this. I have hit the stackoverflow before. I've been working around it by starting up my autotvm script on another thread after I set a huge stack size.
|
We did try this solution but found two problems. First, it is not always working (at least not working for some of us). Second, it is not scalable. The ultimate goal should be a non-recursive graph traversing, but this workaround should solve >90% of current use cases. btw, CI seems failed due to inconsistent return behaviors. |
8ffa4d0
to
1c461c8
Compare
@kevinthesun ci is green now. Could you take a look at the pr? |
…xtraction (apache#5019) * Temporary fix to the stack overflow issue in autotvm task extraction * fix lint * fix graph tuner test
…xtraction (apache#5019) * Temporary fix to the stack overflow issue in autotvm task extraction * fix lint * fix graph tuner test
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.