Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction #5019

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

icemelon
Copy link
Member

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@icemelon
Copy link
Member Author

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmorrill
Copy link
Contributor

Thanks for looking into this. I have hit the stackoverflow before. I've been working around it by starting up my autotvm script on another thread after I set a huge stack size.

threading.stack_size(10 * 1024 * 1024)
t = threading.Thread(...)
t.start()
t.join()

@comaniac
Copy link
Contributor

Thanks for looking into this. I have hit the stackoverflow before. I've been working around it by starting up my autotvm script on another thread after I set a huge stack size.

threading.stack_size(10 * 1024 * 1024)
t = threading.Thread(...)
t.start()
t.join()

We did try this solution but found two problems. First, it is not always working (at least not working for some of us). Second, it is not scalable. The ultimate goal should be a non-recursive graph traversing, but this workaround should solve >90% of current use cases.

btw, CI seems failed due to inconsistent return behaviors.

@icemelon
Copy link
Member Author

@kevinthesun ci is green now. Could you take a look at the pr?

@tqchen tqchen merged commit dbd805c into apache:master Mar 20, 2020
@icemelon icemelon deleted the autotvm-extract branch March 20, 2020 20:58
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
…xtraction (apache#5019)

* Temporary fix to the stack overflow issue in autotvm task extraction

* fix lint

* fix graph tuner test
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
…xtraction (apache#5019)

* Temporary fix to the stack overflow issue in autotvm task extraction

* fix lint

* fix graph tuner test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants