[Relay, TOPI] Refactor Adaptive pool and add 3d support #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinthesun Can you take a look at this? This is for extending adaptive pool op you added in #3085 |
|
@masahi I'll take a look during the weekend. |
jwfromm
approved these changes
Mar 14, 2020
masahi
force-pushed
the
adaptive-pool-3d
branch
from
2af665c
to
90c2219
Compare
|
@kevinthesun Thanks, the diff is not small, but it is due to Relay boilerplate that were mostly copy-pasted from 2d version. The only interesting bits is cpp topi refactoring. I also finished adding 3d model support in our torch frontend, buidling on this PR. We can now load and run resnet 3D from torchvision. I believe this is the first time TVM runs on 3D workload end to end. The diff between this PR is here masahi/tvm@adaptive-pool-3d...masahi:torch-3d |
|
@jwfromm You can easily add adaptive pool 1d, if there is such use case. |
|
Thanks @kevinthesun @jwfromm |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* add stub for nd impl * refactored indices compute * refactored divide step * remove unused variables, add doc * fix lint * add relay op def * add python registration * refactor topi test * update relay tests, but test result is weird * workaround for weird bug * add relay adaptive pool 3d test * add topi tests * update doc for 3d * typo fix * fix lint * add more tests including NDHWC
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* add stub for nd impl * refactored indices compute * refactored divide step * remove unused variables, add doc * fix lint * add relay op def * add python registration * refactor topi test * update relay tests, but test result is weird * workaround for weird bug * add relay adaptive pool 3d test * add topi tests * update doc for 3d * typo fix * fix lint * add more tests including NDHWC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to load resnet 3D from torchvision using torch frontend, and for that I need adaptive avg pool 3d. I refactored the existing topi 2d impl to work with N dimensional input, and added Relay boilerplate for the new 3d version.
please review @kevinthesun @icemelon9 @anijain2305 @jwfromm