[Bugfix][IR][ATTRS] Fix AttrEqual for Array and StrMap, double #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +51,9 @@ TVM_REGISTER_OBJECT_TYPE(DocTextNode); | |||
| class DocText : public DocAtom { | |||
| public: | |||
| explicit DocText(std::string str) { | |||
| if (str.find_first_of("\t\n") != str.npos) { | |||
| LOG(WARNING) << "text node: '" << str << "' should not has tab or newline."; | |||
There was a problem hiding this comment.
Suggested change
| LOG(WARNING) << "text node: '" << str << "' should not has tab or newline."; | |
| LOG(WARNING) << "text: '" << str << "' should not has tab or newline."; |
MarisaKirisame
approved these changes
Mar 12, 2020
zhiics
reviewed
Mar 12, 2020
src/ir/attrs.cc
Outdated
| @@ -344,6 +344,7 @@ bool DictAttrsNode::ContentEqual(const Object* other, AttrsEqual equal) const { | |||
| if (this == other) return true; | |||
| if (other == nullptr) return false; | |||
| if (this->type_index() != other->type_index()) return false; | |||
| LOG(INFO) << "Content equal "; | |||
- Use fuzzy comparison for double. - Removed the hack for BatchNormAttrs and DictAttr. Also removed a warning from text printer printing.
|
Thanks @MarisaKirisame @zhiics |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
…e#5054) - Use fuzzy comparison for double. - Removed the hack for BatchNormAttrs and DictAttr. Also removed a warning from text printer printing.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
…e#5054) - Use fuzzy comparison for double. - Removed the hack for BatchNormAttrs and DictAttr. Also removed a warning from text printer printing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed a warning from text printer printing.
cc @MarisaKirisame @zhiics @merrymercy @jroesch @spectrometerHBH