[Relay][BYOCG] Propagate constant to subgraphs #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
I think @lhutton1 has had an issue that might be related, maybe he can take a look. |
|
Just tested it out with my codegen and works well, thanks for this! |
anijain2305
reviewed
Mar 20, 2020
anijain2305
approved these changes
Mar 20, 2020
|
Thanks everybody. This is now merged. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* bind constant to subgraphs * con -> constant
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* bind constant to subgraphs * con -> constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all constants are not propagated to the functions that will be handled by external codegen. This may cause some performance issue if a function is frequently used as you will need to pass the constants multiple times to accelerates. This PR binds the constants to the new functions and propagate them. As expected, this will need the 3rd-party codegen to handle the constants by themselves.
@comaniac @mbaret @soiferj @trevor-m @tqchen