-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution #5148
Conversation
8133ba6
to
6f6b8d8
Compare
After thinking it a bit more, lower the plevel could only change the default schedule. However, when the users tune it by themselves, they will still introduce this |
You are right. That's the intention of the
@icemelon9 do you have any suggestions? |
Yes, let's comment out this implementation temporarily. Could you add a Todo with pointer to the issue in the discussion to both arm cpu strategy and the topi file? |
Sure. I have added comments as your advice. @comaniac @icemelon9 please have a look again |
Thanks @icemelon9 @comaniac for reviewing and giving advices. |
… convolution (apache#5148) * [Strategy][ARM CPU] Low the plevel of contrib spatial pack of depthwise convolution * address comments
… convolution (apache#5148) * [Strategy][ARM CPU] Low the plevel of contrib spatial pack of depthwise convolution * address comments
The spatial pack schedule of depthwise convolution is under the tag of
contrib
before introducing op strategy. However, as this discuss: https://discuss.tvm.ai/t/autotuner-incorrect-result-after-tuning-mobilenetv2-on-arm-cpu/6088, we maybe will meet incorrect result use this schedule. I ever met this problem on some hardware platform too. However, it is not 100% could produce and happened rarely. Correct result should be firstly, so let us make our previous depthwise schedule be the default, not thecontrib
spatial pack schedule.@icemelon9 Could you help to review the code?