[VTA][Refactor] Introducing VTA_HW_PATH for easier migration #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Mar 28, 2020
tqchen
requested changes
Mar 28, 2020
| import os | ||
|
|
||
| def get_vta_hw_path(): | ||
| """Get the VTA HW path.""" |
There was a problem hiding this comment.
It is still better to have a default
There was a problem hiding this comment.
thanks I've addressed them
vta/vta-hw/config/pkg_config.py
Outdated
|
|
||
| def get_tvm_path(): | ||
| """Get the TVM path.""" | ||
| TVM_PATH = os.getenv('TVM_PATH', None) |
There was a problem hiding this comment.
yes, I'll set one
tqchen
approved these changes
Mar 29, 2020
|
@tmoreau89 Seems master CI is broken now. Could you please take a look? |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVM community has voted for the
vta/vta-hwdirectory migration (see #5102 for context). To make the switch easier:VTA_HW_PATHenvironment variablevta-hwrepo, we're introducing theTVM_PATHenvironment variable to point to TVM repovta-hwfrom doxygen --vta-hwwill have it's own doxygen generated docsvta-hwbecause it makes more sense to couple that with the config files.