Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR][Debug] Add dump and print for debugging (NFC) #5207

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

wpan11nv
Copy link
Contributor

@wpan11nv wpan11nv commented Apr 1, 2020

[Debug] Add Dump function for Object type (NFC)

Signed-off-by: Wei Pan weip@nvidia.com

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@tqchen
Copy link
Member

tqchen commented Apr 1, 2020

Ideally we want to minimize the number of member functions being provide. Given that this is an utility function, it would be better to make it as a public global function rather than a member function. Perhaps we should simply fix tvm::Dump.

Signed-off-by: Wei Pan <weip@nvidia.com>
@wpan11nv
Copy link
Contributor Author

wpan11nv commented Apr 1, 2020

Ideally we want to minimize the number of member functions being provide. Given that this is an utility function, it would be better to make it as a public global function rather than a member function. Perhaps we should simply fix tvm::Dump.

That is ok to me. Minor addition to Dump works fine too. FYI, vscode watch cannot find tvm::Dump, but lldb command line works.

@tqchen tqchen merged commit 15b1751 into apache:master Apr 2, 2020
@tqchen
Copy link
Member

tqchen commented Apr 2, 2020

Thanks @wpan11nv

@wpan11nv wpan11nv deleted the add_dump branch April 10, 2020 17:42
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
Signed-off-by: Wei Pan <weip@nvidia.com>
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants