Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager. #5225

Merged
merged 4 commits into from
Apr 3, 2020
Merged

[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager. #5225

merged 4 commits into from
Apr 3, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Apr 3, 2020

  • SplitHostDevice
  • ThreadSync
  • BindDevice
  • LowerThreadAllreduce
  • Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.

@tqchen
Copy link
Member Author

tqchen commented Apr 3, 2020

cc @zhiics @yzhliu @ZihengJiang

@tqchen tqchen mentioned this pull request Apr 3, 2020
Closed
@tqchen
[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager.
8cf233d 
- SplitHostDevice
- ThreadSync
- BindDevice
- LowerThreadAllreduce
- Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.
zhiics
zhiics reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos

python/tvm/tir/transform/transform.py Outdated Show resolved Hide resolved
src/tir/transforms/bind_device_type.cc Outdated Show resolved Hide resolved
src/tir/transforms/bind_device_type.cc Outdated Show resolved Hide resolved
@tqchen
Copy link
Member Author

tqchen commented Apr 3, 2020

cc @zhiics please take another look

@zhiics zhiics merged commit 75e936e into apache:master Apr 3, 2020
zhiics pushed a commit to comaniac/tvm that referenced this pull request Apr 7, 2020
@tqchen @zhiics
[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manag…
dffc80c 
…er. (apache#5225)

* [REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager.

- SplitHostDevice
- ThreadSync
- BindDevice
- LowerThreadAllreduce
- Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.

* Address comments, fix tests.

* Fix relay tests

* Explicit move
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@tqchen
[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manag…
0797ac4 
…er. (apache#5225)

* [REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager.

- SplitHostDevice
- ThreadSync
- BindDevice
- LowerThreadAllreduce
- Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.

* Address comments, fix tests.

* Fix relay tests

* Explicit move
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@tqchen @zhiics
[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manag…
044715b 
…er. (apache#5225)

* [REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager.

- SplitHostDevice
- ThreadSync
- BindDevice
- LowerThreadAllreduce
- Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.

* Address comments, fix tests.

* Fix relay tests

* Explicit move
@tqchen tqchen deleted the split branch April 21, 2020 00:02
dpankratz pushed a commit to dpankratz/incubator-tvm that referenced this pull request Apr 24, 2020
@tqchen @dpankratz
[REFACTOR][TIR] Migrate most of low-level build to use the Pass Manag…
1e9ea43 
…er. (apache#5225)

* [REFACTOR][TIR] Migrate most of low-level build to use the Pass Manager.

- SplitHostDevice
- ThreadSync
- BindDevice
- LowerThreadAllreduce
- Provide a temp fix for printing IRModule with PrimFunc before the formal text printer.

* Address comments, fix tests.

* Fix relay tests

* Explicit move
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqchen @zhiics