Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend][TFLite] support for FILL and SPLIT_V operators #5330

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

maheshambule
Copy link
Contributor

@siju-samuel, @shoubhik, @kevinthesun Please help in review.

python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Show resolved Hide resolved
@maheshambule
Copy link
Contributor Author

@siju-samuel Thanks. Made the changes.

Copy link
Member

@siju-samuel siju-samuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshambule
Copy link
Contributor Author

@siju-samuel, Thanks.
@kevinthesun, Please help in review and merge.

Copy link
Contributor

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I would like #5392 to be merged in so that we have some CI for these new operators which are newer than 1.13.1 which is what our CI is.

python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
@maheshambule
Copy link
Contributor Author

@u99127 I have merged the master and removed the duplicate code.

@maheshambule
Copy link
Contributor Author

@u99127, @siju-samuel, @FrozenGene, Could you please help in merging this PR.

Copy link
Contributor

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can't do the merge myself.

@FrozenGene FrozenGene merged commit 063ba63 into apache:master Apr 29, 2020
@FrozenGene
Copy link
Member

Thanks @maheshambule @siju-samuel @u99127 merged now

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 9, 2020
* tflite spliv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* remove unnecessary operator check
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 18, 2020
* tflite spliv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* remove unnecessary operator check
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 18, 2020
* tflite spliv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* TFLITE fill and splitv ops

* remove unnecessary operator check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants