Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove() TemporaryFile in __del__. #5414

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Don't remove() TemporaryFile in __del__. #5414

merged 1 commit into from
Apr 23, 2020

Commits on Apr 22, 2020

  1. Don't remove() TempDirectory in __del__ after atexit hook runs. 

     * Use atexit to remove TempDirectory before interpreter shutdown.
 * Can't rely on complex functions from __del__ anyway.
 * Fixes warning message on my box:
       Exception ignored in: <function TempDirectory.__del__ at 0x12be10680>
       Traceback (most recent call last):
        File ".../tvm/python/tvm/contrib/util.py", line 55, in __del__
        File ".../tvm/python/tvm/contrib/util.py", line 51, in remove
        File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py", line 509, in rmtree
        AttributeError: 'NoneType' object has no attribute 'path'
    @areusch
    areusch committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    088f760 View commit details
    Browse the repository at this point in the history