Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUNTIME][OBJECT] Introduce static slots for common objects. #5423

Merged
merged 1 commit into from
Apr 24, 2020
Merged

[RUNTIME][OBJECT] Introduce static slots for common objects. #5423

merged 1 commit into from
Apr 24, 2020

Commits on Apr 23, 2020

  1. [RUNTIME][OBJECT] Introduce static slots for common objects. 

    The _type_child_slots can be used to enable quick type checking optimization
by checking the whether the type index is within the bound.

This PR enables these static slots:

- Introduce a static assert to avoid the scenario when a developer forget to
  _type_child_slots when the field is set for the type's parent.
- Revamp and assign static type index to common runtime objects
- Add a DumpTypeTable call to allow developer monitor the current situation
  of type table and offers suggestions for the slots(ideally the slots equals
  the number of children so there is no overflow.
    @tqchen
    tqchen committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    3f5896f View commit details
    Browse the repository at this point in the history