[Relay, Topi] [Frontend][TFLite, MXNet] ReverseSequence operator #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maheshambule <mahesh_ambule@persistent.com>
Signed-off-by: maheshambule <mahesh_ambule@persistent.com>
Signed-off-by: maheshambule <mdambule07@gmail.com>
Signed-off-by: maheshambule
MXNet SequenceReverse implementation
maheshambule
changed the title
|
cc: @FrozenGene, @masahi, @yongwww |
|
ping @FrozenGene, @masahi Please take a look. |
|
@anijain2305 - Please review |
|
@siju-samuel Pinging for review if interested :) |
siju-samuel
requested changes
Jun 10, 2020
|
@siju-samuel, rebased to master. PTAL. |
cbalint13
approved these changes
Jun 13, 2020
siju-samuel
requested changes
Jun 14, 2020
|
@siju-samuel, Thanks. Fixed as per the review comments. |
anijain2305
approved these changes
Jun 16, 2020
|
@siju-samuel Thanks for the review. Can you please look again? |
|
Thanks @siju-samuel @dhruvaray @cbalint13 @maheshambule this is merged |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…che#5495) * TFLite reverse_sequence op * TFLite add_n implementation * reverse_sequence implementation * reverse_sequence implementation * reverse sequence * TOPI,Relay,TFLite - Reverse Sequence Signed-off-by: maheshambule <mahesh_ambule@persistent.com> * Reverse Sequence small fixes Signed-off-by: maheshambule <mahesh_ambule@persistent.com> * lint fixes Signed-off-by: maheshambule <mdambule07@gmail.com> * TFLite reverse_sequence op Signed-off-by: maheshambule * MXNet SequenceReverse implementation * clang format * clang format * review comment fixes
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…che#5495) * TFLite reverse_sequence op * TFLite add_n implementation * reverse_sequence implementation * reverse_sequence implementation * reverse sequence * TOPI,Relay,TFLite - Reverse Sequence Signed-off-by: maheshambule <mahesh_ambule@persistent.com> * Reverse Sequence small fixes Signed-off-by: maheshambule <mahesh_ambule@persistent.com> * lint fixes Signed-off-by: maheshambule <mdambule07@gmail.com> * TFLite reverse_sequence op Signed-off-by: maheshambule * MXNet SequenceReverse implementation * clang format * clang format * review comment fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://www.tensorflow.org/api_docs/python/tf/reverse_sequence
Reverse op's compute def is refactored and is now being invoked as a special case of RevereseSequence op.
@jwfromm, @FrozenGene, @kevinthesun, @siju-samuel @mbaret @u99127 Could you please review?