-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] symbolic max_output_size #5844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with 20000 random boxes (score_threshold=0, iou_threshold=0.6, max_output_size=7) on my local env., the execution time of nms decreased to 0.003057119846343994 second from 0.39738729953765867 |
kevinthesun
reviewed
Jun 18, 2020
Can we also add a TODO to topi cuda nms? |
yongwww
force-pushed
the
max_outputs
branch
3 times, most recently
from
June 25, 2020 23:02
def4ac1
to
e8192a2
Compare
kevinthesun
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @yongwww |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
* symbolic max_output_size * pylint * fix ci
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
* symbolic max_output_size * pylint * fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kevinthesun @zhiics @icemelon9 @lixiaoquan