[ONNX] Fix an issue with #5755 and add Batch norm unit tests. #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the fix, LGTM. |
tqchen
approved these changes
Jun 18, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masahi
@jwfromm discovered an issue with #5755 , infer_value chokes on ops with multiple outputs. I already knew this for Tuple, this adds a work around to infer batch_norm with the following TupleGetItem node instead of by itself.
In adding a regression test, I discovered that the Onnx importer for batch norm wasn't tested, so I added a unit test for it.
Are you guys aware of any other multi-output ops that might suffer the same problem?