[RELAY] Allow non-CSourceModules to compile #5884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent patch added a check so that external modules must be a CSourceModule. Generally that's not the case, so this patch instead queries whether or not the external module implements "get_const_vars". Change-Id: I2f022cb904d9636639132e26985f5c66876b48bb
zhiics
reviewed
Jun 22, 2020
|
I think this is a cleaner alternative for now. Currently we can't rebase on top of your commit because of that CHECK. Our Ethos-N integration uses a completely custom runtime that doesn't need any constant metadata stored. |
|
You can use our code here for a better fix: |
|
Seeing as that part doesn't look like it has dependencies on the JSON runtime stuff, could you publish it as a standalone PR and I'll abandon this one? |
|
Superseded by #5885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent patch added a check so that external modules must be a CSourceModule. Generally that's not the case, so this patch instead queries whether or not the external module implements "get_const_vars".