PyTorch frontend: fix handling of duplicate use of a model weight #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens e.g. in shared input/output embeddings in BERT or siamese networks. Thank you @siju-samuel for reporting.
|
@siju-samuel please take a look |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…ache#5897) This happens e.g. in shared input/output embeddings in BERT or siamese networks. Thank you @siju-samuel for reporting.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…ache#5897) This happens e.g. in shared input/output embeddings in BERT or siamese networks. Thank you @siju-samuel for reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens e.g. in shared input/output embeddings in BERT
or siamese networks.
Thank you @siju-samuel for reporting (in the post-merge discussion in #5887).