Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a few gradients #5899

Merged
merged 1 commit into from
Jun 23, 2020
Merged

add a few gradients #5899

merged 1 commit into from
Jun 23, 2020

Conversation

t-vi
Copy link
Contributor

@t-vi t-vi commented Jun 23, 2020

I don't think #2562 is up to date, but hey...

@t-vi
Copy link
Contributor Author

t-vi commented Jun 23, 2020

@siju-samuel @kevinthesun you have recent commits in the gradients
With the tests, it should be relatively low-risk.

junrushao
junrushao approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented Jun 23, 2020

cc @jroesch @MarisaKirisame

MarisaKirisame
MarisaKirisame approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@MarisaKirisame MarisaKirisame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit 81e8cfc into apache:master Jun 23, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
@t-vi
add a few gradients (apache#5899)
9cda6e8
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
@t-vi @zhiics
add a few gradients (apache#5899)
bae43a6
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@MarisaKirisame MarisaKirisame MarisaKirisame approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-vi @tqchen @MarisaKirisame @junrushao