[TFLite, QNN] Slice op #6217
Closed
[TFLite, QNN] Slice op #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siju-samuel Please review. |
siju-samuel
reviewed
Aug 6, 2020
| assert len(output_tensors) == 1, "There should be only 1 output tensor" | ||
| output_tensor = output_tensors[0] | ||
| assert self.has_same_qnn_params(input_tensor, output_tensor), \ | ||
| "TFLite reshape requires input and output scale and zero points to be equal" |
There was a problem hiding this comment.
Tflite reshape -> Tflite slice
Comment on lines
+380
to
+381
| input_range = {'in_data': (-100, 100)} if quantized else None | ||
| compare_tflite_with_tvm([data], ['in_data:0'], [in_data], [out], |
There was a problem hiding this comment.
This 2 common statements, put outside if-else block.
siju-samuel
requested changes
Aug 21, 2020
LGTM modulo @siju-samuel 's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFLite quantized slice op has same input and output qnn params. Just adding a check and a test case.
@d-smirnov Please take a look at this PR if it can help simplify - #6018 My goal was to keep the changes minimal here.
@u99127