Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Update build support for cross compiling apps/cpp_rpc with OpenCL #6229

Merged
merged 3 commits into from
Aug 11, 2020
Merged

[RPC] Update build support for cross compiling apps/cpp_rpc with OpenCL #6229

merged 3 commits into from
Aug 11, 2020

Conversation

csullivan
Copy link
Contributor

Standardize build support for building and cross compiling apps/cpp_rpc with cmake.

  • Add cmake coverage for building the C++ RPC server binary and update documentation.
  • Add support for linking against custom OpenCL SDK employing a custom find_opencl macro. This can be useful when cross compiling with a custom OpenCL device driver.

cd arm_runtime
cmake .. -DCMAKE_CXX_COMPILER="/path/to/cross compiler g++/"
make runtime
- Configure the tvm cmake build with `config.cmake` ensuring that `USE_CPP_RPC` is set to `ON` in the config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should tell users how to cross compile C++ rpc for embed linux platform (like Ubuntu / rasp), not only android.

@tqchen
Copy link
Member

tqchen commented Aug 7, 2020

cc @FrozenGene

@FrozenGene
Copy link
Member

ping @csullivan

csullivan and others added 3 commits August 10, 2020 10:02
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
@csullivan
Copy link
Contributor Author

@FrozenGene Thanks for the good suggestions. I updated the documentation and build system for embedded linux to use the same flow as previously described the docs.

@FrozenGene FrozenGene merged commit 14f4efe into apache:master Aug 11, 2020
@FrozenGene
Copy link
Member

FrozenGene commented Aug 11, 2020

Thanks @csullivan I've verified it and it works.

wjliu1998 pushed a commit to wjliu1998/incubator-tvm that referenced this pull request Aug 13, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
…CL (apache#6229)

* Standardize support for building and cross compiling apps/cpp_rpc.
* Add cmake coverage for building the C++ RPC server binary
  and update documentation.
* Add support for linking against custom OpenCL SDK employing
  a custom find_opencl macro. This can be useful when cross
  compiling with a custom OpenCL device driver.

* Update OpenCL related documentation.

* Add embedded linux build instructions to apps/cpp_rpc/README.md and
ensure pthread is linked against when OS=Linux is defined. Remove
outdated apps/cpp_rpc/Makefile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants