[ONNX] Update slice to infer attributes when not graph inputs #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csullivan
changed the title
masahi
approved these changes
Aug 17, 2020
|
Thanks @csullivan @mbrookhart |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…#6276) * Update ONNX Slice converter to infer slice attributes when necessary. * Linting
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…#6276) * Update ONNX Slice converter to infer slice attributes when necessary. * Linting
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…#6276) * Update ONNX Slice converter to infer slice attributes when necessary. * Linting
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…#6276) * Update ONNX Slice converter to infer slice attributes when necessary. * Linting
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…#6276) * Update ONNX Slice converter to infer slice attributes when necessary. * Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slice converter was only checking for its input attributes in the list of graph parameters which fails when the attributes are calculated as is the case in DeeplabV3 (MNv2). Update the importer to infer the slice attribute values when this is the case.