-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPI] Add einsum operator #6370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint problem, remember you can use tests/lint/git-clang-format.sh to lint cpp code automatically.
c735e9e
to
64b31c7
Compare
e779c08
to
f9f7e76
Compare
will do shortly. |
pls also rebase and retrigger the ci. |
7e93d3d
to
71916d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tqchen @hzfan @junrushao1994 could you help to do another round of review?
also cc @ZihengJiang |
@hanke580 Nice work! I did not realize that we already has an implementation for |
Gentle ping @tqchen @ZihengJiang seems @hanke580 has resolved your comment. We could go on following steps. |
LGTM! |
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.