Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Add einsum operator #6370

Merged
merged 14 commits into from
Feb 3, 2021
Merged

[TOPI] Add einsum operator #6370

merged 14 commits into from
Feb 3, 2021

Conversation

hanke580
Copy link
Contributor

@hanke580 hanke580 commented Sep 1, 2020

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

include/tvm/topi/transform.h Outdated Show resolved Hide resolved
include/tvm/topi/transform.h Outdated Show resolved Hide resolved
include/tvm/topi/transform.h Outdated Show resolved Hide resolved
include/tvm/topi/transform.h Outdated Show resolved Hide resolved
Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint problem, remember you can use tests/lint/git-clang-format.sh to lint cpp code automatically.

include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
@hanke580 hanke580 force-pushed the einsum branch 2 times, most recently from c735e9e to 64b31c7 Compare September 9, 2020 08:17
@tqchen tqchen changed the base branch from master to main October 11, 2020 18:20
@tqchen
Copy link
Member

tqchen commented Oct 28, 2020

@yzhliu @hanke580 please followup :)

@junrushao
Copy link
Member

@yzhliu @hzfan @tqchen Would you guys take a second look and update with further actions? Thanks a lot!

@yzhliu
Copy link
Member

yzhliu commented Jan 6, 2021

will do shortly.

include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
python/tvm/topi/transform.py Outdated Show resolved Hide resolved
@yzhliu
Copy link
Member

yzhliu commented Jan 8, 2021

pls also rebase and retrigger the ci.

@hanke580 hanke580 force-pushed the einsum branch 2 times, most recently from 7e93d3d to 71916d6 Compare January 12, 2021 04:21
Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tqchen @hzfan @junrushao1994 could you help to do another round of review?

@tqchen
Copy link
Member

tqchen commented Jan 20, 2021

also cc @ZihengJiang

@tqchen tqchen assigned ZihengJiang and yzhliu and unassigned yzhliu Jan 20, 2021
@ZihengJiang
Copy link
Contributor

@hanke580 Nice work! I did not realize that we already has an implementation for einsum. I will take a closer look at it!

python/tvm/topi/einsum.py Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
include/tvm/topi/einsum.h Show resolved Hide resolved
include/tvm/topi/einsum.h Outdated Show resolved Hide resolved
@FrozenGene
Copy link
Member

Gentle ping @tqchen @ZihengJiang seems @hanke580 has resolved your comment. We could go on following steps.

@ZihengJiang
Copy link
Contributor

LGTM!

@junrushao junrushao merged commit 618ef9e into apache:main Feb 3, 2021
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
* [TOPI] Einsum
* Fix tuple
* fix oshape

* * test

* * Fix lint

* * Remove useless define

* * Move to einsum header file

* * Fix single value situation

* * Fix CamelASE

* * Print stride

* * Fix single input bug

* * fix lint

* * Fix lint and add comments

* * create test einsum

* * Fix lint

* * Fix comments
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
* [TOPI] Einsum
* Fix tuple
* fix oshape

* * test

* * Fix lint

* * Remove useless define

* * Move to einsum header file

* * Fix single value situation

* * Fix CamelASE

* * Print stride

* * Fix single input bug

* * fix lint

* * Fix lint and add comments

* * create test einsum

* * Fix lint

* * Fix comments
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
* [TOPI] Einsum
* Fix tuple
* fix oshape

* * test

* * Fix lint

* * Remove useless define

* * Move to einsum header file

* * Fix single value situation

* * Fix CamelASE

* * Print stride

* * Fix single input bug

* * fix lint

* * Fix lint and add comments

* * create test einsum

* * Fix lint

* * Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants