-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][Tensorflow] Fix TF 1.15 conv2d_transpose parsing #6589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtuyls Good catch. Thanks for the contribution.
Can you add a testcase convering this scenario as well?
@siju-samuel I guess this issue is really caused by not using AddShapesToGraphDef but I think it's still useful to include the small changes to cover this case. So I added checks for that to the Tensorflow convolution tests. Could you have a look? Additionally, we could maybe add tests for this case to the other operations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jtuyls @siju-samuel |
Fix for Tensorflow 1.15.0 conv2d_transpose parsing. Specifically, attr["_output_shapes"][0] can be None.
Following snippet can be used to create a model for reproducing the bug (run with TF 1.15.0):
In general, I think it might be useful to adjust the CI to run the frontend tests with multiple versions of the the external frameworks to verify compatibility with the versions we want to support?
@siju-samuel @masahi, could you have a look?