-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch, Quantization] Necessary workaround to prepare for 1.6 update #6602
Conversation
1f2fad6
to
63f3f7f
Compare
@siju-samuel @anijain2305 can you merge this? It is a prereq for upgrading our CI to the latest pytorch version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few nits
63f3f7f
to
1a18815
Compare
thanks @siju-samuel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6186b8a
to
5bb926f
Compare
Thanks @siju-samuel |
…pache#6602) * add support for 1.6 quantized models * fix lint * move version check function to a common utils * fix lint Co-authored-by: masa <masa@pop-os.localdomain>
…pache#6602) * add support for 1.6 quantized models * fix lint * move version check function to a common utils * fix lint Co-authored-by: masa <masa@pop-os.localdomain>
…pache#6602) * add support for 1.6 quantized models * fix lint * move version check function to a common utils * fix lint Co-authored-by: masa <masa@pop-os.localdomain>
…pache#6602) * add support for 1.6 quantized models * fix lint * move version check function to a common utils * fix lint Co-authored-by: masa <masa@pop-os.localdomain>
A part of #6594
This the workaround for the state_dict bug introduced in 1.6. With this fix, I verified locally that I can run our quantization tests on 1.6. We can now support quantized models from v1.4 to v1.6.
please review @siju-samuel @t-vi @anijain2305