Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Object detection support update for PyTorch 1.6 #6659

Merged
merged 6 commits into from
Oct 12, 2020

Conversation

masahi
Copy link
Member

@masahi masahi commented Oct 10, 2020

cc @kevinthesun @yongwww @t-vi @zhiics

I confirmed locally that it works with 1.6, but since CI is still at 1.4, we cannot test 1.6 support on the CI yet. I appreciate if you can also verify locally.

@masahi masahi mentioned this pull request Oct 10, 2020
4 tasks
@masahi masahi marked this pull request as ready for review October 10, 2020 13:18
@tqchen tqchen changed the base branch from master to main October 11, 2020 18:16
Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit b277f18 into apache:main Oct 12, 2020
@kevinthesun
Copy link
Contributor

Thanks @masahi @zhiics
This is awesome!

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
* update split

* fix

* cast nms output to int64

* add more comment and numel test

* fix lint

* also supported the latest master (1.7)

Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
* update split

* fix

* cast nms output to int64

* add more comment and numel test

* fix lint

* also supported the latest master (1.7)

Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
* update split

* fix

* cast nms output to int64

* add more comment and numel test

* fix lint

* also supported the latest master (1.7)

Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
* update split

* fix

* cast nms output to int64

* add more comment and numel test

* fix lint

* also supported the latest master (1.7)

Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
* update split

* fix

* cast nms output to int64

* add more comment and numel test

* fix lint

* also supported the latest master (1.7)

Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants