[Relay] Mix mode type inference #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixiaoquan
force-pushed
the
non_recursive_infer
branch
from
dc66e71
to
8228168
Compare
jroesch
reviewed
Oct 20, 2020
| * | ||
| * fcheck_visited and fvisit_leaf are templated to encourage compiler inlining. | ||
| */ | ||
| template <typename FCheckVisited, typename FVisitLeaf> |
There was a problem hiding this comment.
Why do we need to expose this in the header?
There was a problem hiding this comment.
It's a template function and we need to use it in type_infer.cc
There was a problem hiding this comment.
InferType directly extends ExprFunctor instead of using ExprVisitor or ExprMutator
lixiaoquan
force-pushed
the
non_recursive_infer
branch
from
8228168
to
f31847a
Compare
|
@lixiaoquan sorry I forgot to merge this one, going to land now. |
jroesch
approved these changes
Nov 6, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbrookhart @jroesch Could you please review? Thanks