[FIX] Fix cublas batch matmul #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update batch_matmul.py
sxjscience
force-pushed
the
fix_cublas_batch_matmul
branch
from
eac559b
to
e1116a3
Compare
comaniac
requested changes
Oct 20, 2020
There was a problem hiding this comment.
@merrymercy the CI failed at the Ansor tutorial. Would you mind take a look?
comaniac
approved these changes
Oct 20, 2020
|
Why do we need this attribute in |
|
The reason is that the code here always assume that there is an |
|
I checked the implementation. I think we can remove the oshape arg in the topi implementation and we can enable broadcasting at batch axis by default. cc @jwfromm |
sxjscience
changed the title
6 tasks
|
Per offline discussion with @icemelon9 , I will have a separate PR to remove the oshape flag directly. |
|
Thanks @sxjscience @comaniac |
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Oct 23, 2020
* Update batch_matmul.py Update batch_matmul.py * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
* Update batch_matmul.py Update batch_matmul.py * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* Update batch_matmul.py Update batch_matmul.py * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* Update batch_matmul.py Update batch_matmul.py * fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* Update batch_matmul.py Update batch_matmul.py * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
@comaniac The issue is the same as the cblas_batch_matmul issue in #6699.