Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CHECK* with ICHECK* #6745

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Replace CHECK* with ICHECK* #6745

merged 1 commit into from
Oct 24, 2020

Conversation

rkimball
Copy link
Contributor

@rkimball rkimball commented Oct 23, 2020 •
edited
Loading

  • I apologize for large size of this PR
  • To keep the size down some only /include and /src directories were updated
  • Instance of CHECK are placed with ICHECK
  • Instances of CHECK_GT, CHECK_LT, etc. replaced with ICHECK_GT, ICHECK_LT, etc.
  • The file include/tvm/support/logging.h is not modified since it is where ICHECK is defined and ICHECK ultimately calls CHECK
  • In include/tvm/support/logging.h the tvm:: namespace was explicitly added to kTVM_INTERNAL_ERROR_MESSAGE to address compile errors.
  • Files in runtime/crt not updated to use ICHECK

@rkimball rkimball marked this pull request as ready for review October 24, 2020 19:18
@jroesch jroesch merged commit 1831c17 into apache:main Oct 24, 2020
zhiics pushed a commit to zhiics/tvm that referenced this pull request Oct 28, 2020
@rkimball @zhiics
Update include and src dir CHECK* to ICHECK* (apache#6745)
fe6684b
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 29, 2020
@rkimball
Update include and src dir CHECK* to ICHECK* (apache#6745)
76a5719
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@rkimball
Update include and src dir CHECK* to ICHECK* (apache#6745)
3a754cc
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@rkimball
Update include and src dir CHECK* to ICHECK* (apache#6745)
9e5cfd7
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@rkimball @trevor-m
Update include and src dir CHECK* to ICHECK* (apache#6745)
eb8e046
@rkimball rkimball deleted the bob/err branch January 8, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jroesch jroesch jroesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkimball @jroesch