Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMC] use common function to obtain target from --target value on 'tvmc compile' #6788

Merged
merged 1 commit into from
Oct 29, 2020
Merged

[TVMC] use common function to obtain target from --target value on 'tvmc compile' #6788

merged 1 commit into from
Oct 29, 2020

Conversation

leandron
Copy link
Contributor

This solves a TODO item on TVMC, using a common function to obtain the target from --target in the command line. The common function is already used in tvmc tune.

cc @comaniac @FrozenGene

…vmc compile'

 - This is solving a TODO item on tvmc
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also file an issue to list all the TODOs we discussed in previous PRs so that we can easily track the status? Thanks.

@leandron leandron mentioned this pull request Oct 29, 2020
7 tasks
@leandron
Copy link
Contributor Author

LGTM. Can you also file an issue to list all the TODOs we discussed in previous PRs so that we can easily track the status? Thanks.

I raised #6792 to cover the pending items on TVMC backlog.

@leandron
Copy link
Contributor Author

If you're ok with the issue I filed to tackle backlog items, can we merge this one?

@comaniac comaniac merged commit 8dfe706 into apache:main Oct 29, 2020
@comaniac
Copy link
Contributor

Thanks @leandron

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
…vmc compile' (apache#6788)

- This is solving a TODO item on tvmc
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
…vmc compile' (apache#6788)

- This is solving a TODO item on tvmc
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
…vmc compile' (apache#6788)

- This is solving a TODO item on tvmc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants