-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch, CI] Update to PyTorch 1.7 #6811
Conversation
@masahi you should now have access |
f8a0124
to
94c1741
Compare
@tqchen I've uploaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look. A couple minor comments.
@masahi We don't use images from Jenkinsfile in PRs due to security concerns. the Jenkinsfile have to be pushed into ci-docker-staging(you can push directly to that branch) for stage testing. Then the results will be available here https://ci.tlcpack.ai/job/tvm/job/ci-docker-staging/ After the stage testing passes, we then send the PR to the mainline to update the image. Note that you may want to create temporary tags like v0.72-t0 in cases where we want to build the docker image multiple times, this usually happens when an error occurs during the upgrade |
f07f78a
to
3ce7806
Compare
Tests on the staging branch https://ci.tlcpack.ai/job/tvm/job/ci-docker-staging/34/ have passed, but this PR is still running on the older image. I'll close this one and try open another PR. |
A part of #6594. Updated frontend tests and the install script to install
torch==1.7.0 torchvision==0.8.1
@tqchen so according to https://tvm.apache.org/docs/contribute/pull_request.html#ci-environment, the next step after this PR is to build and upload a new docker image, and update
Jenkinsfile
. Since I have a committership, I can do those steps, is that right? But I've just created an account with dockerhub (https://hub.docker.com/u/masahi129), so I don't think I have a privilege to push undertlcpack
org).I'm not familiar with docker workflows, but I want to learn how to update CI.