-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conv1d_transpose speedup #6840
conv1d_transpose speedup #6840
Conversation
Speedup transposed 1d convolution by eliminating unnecessary multiplications by data values which contain zeroes, for stride greater then 1. Below are current vs proposed latency numbers for various transposed conv1d parameters: ` |
f77c5e4
to
0777e36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
@vinx13 Can you PTAL for CUDA stuff? |
d93ece9
to
86bbc54
Compare
Improve performance of transposed convolution by avoiding redundant multiplication by zero values from dilated data.
86bbc54
to
e27f6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments @alexgl-github ! LGTM
Thanks @alexgl-github @anijain2305 @giuseros |
Improve performance of transposed convolution by avoiding redundant multiplication by zero values from dilated data. Co-authored-by: Ubuntu <ubuntu@ip-172-31-74-104.ec2.internal>
Improve performance of transposed convolution by avoiding redundant multiplication by zero values from dilated data. Co-authored-by: Ubuntu <ubuntu@ip-172-31-74-104.ec2.internal>
Improve performance of transposed convolution by avoiding redundant multiplication by zero values from dilated data. Co-authored-by: Ubuntu <ubuntu@ip-172-31-74-104.ec2.internal>
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.