[QNN] Dynamic scale, zero point in qnn.op.dequantize #6849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
reviewed
Nov 4, 2020
| @@ -29,6 +29,9 @@ | |||
| import tvm | |||
| import tvm.testing | |||
| from tvm import relay | |||
| from tvm.contrib import graph_runtime | |||
There was a problem hiding this comment.
This is a test script for pytorch frontend... Please move these changes to relay/test_op_qnn_dequantize.py and relay/test_op_qnn_quantize.py
There was a problem hiding this comment.
Moved - thanks for pointing that out
masahi
approved these changes
Nov 6, 2020
|
thanks @electriclilies |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* add dynamic dequantize * register quantize and dequantize as opaque * make tests better * black * remove main fn * fix black again * move tests * fix import * fix import again * try again * fix import
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* add dynamic dequantize * register quantize and dequantize as opaque * make tests better * black * remove main fn * fix black again * move tests * fix import * fix import again * try again * fix import
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* add dynamic dequantize * register quantize and dequantize as opaque * make tests better * black * remove main fn * fix black again * move tests * fix import * fix import again * try again * fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the qnn.op.dequantize op to accept dynamic scales and zero points. #6782 made similar changes to the qnn.quantize op.
I also added unit tests to the qnn testing to make sure that the dynamic scale and zero points work for both quantize and dequantize.
@jwfromm @masahi Please take a look