-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoscheduler support to tvmc #7070
Conversation
giuseros
commented
Dec 9, 2020
- Add an autoschedule module to tvmc
- Extract common tuning option between autotuner and autoscheduler
- Add testing
Hi @comaniac , @leandron ,
|
6ade51f
to
bb39526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much clean now and overall LGTM. Thanks!
The last batch of comments are mostly about refactoring.
I'm ok with this for now.
No worries. It is no longer an issue based on the latest implementation. It is reasonable to have separate functions for two frameworks launched by the same CLI command.
You're right. It's always hard to keep the proper unit test scope of TVMC. We should have a thread to discuss all of them and make a agreement. cc @leandron |
- Add an autoschedule module to tvmc - Extract common tuning option between autotuner and autoscheduler - Add testing
Change-Id: I207872757473210681d9db04bfdcd2c5e6deaa05
a51c072
to
881dde0
Compare
Hi @comaniac , @leandron ,
Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thanks. Just a naming nit.
Change-Id: I11f73c9b32e83c013cfb2224ccce06f60a128af7
* Add autoscheduler support to tvmc - Add an autoschedule module to tvmc - Extract common tuning option between autotuner and autoscheduler - Add testing * Linting and small bug-fixing * Addressing comments and refactoring * Fix linting * rebasing * Addressing comments - 2 * Addressing comments -3 Change-Id: I207872757473210681d9db04bfdcd2c5e6deaa05 * Addressing comments - 4 Change-Id: I11f73c9b32e83c013cfb2224ccce06f60a128af7
For x86 cpu, it is recommended to use
This can make the measurement faster and more accurate. We should add this to tvmc. |
Hi @merrymercy , |
* Add autoscheduler support to tvmc - Add an autoschedule module to tvmc - Extract common tuning option between autotuner and autoscheduler - Add testing * Linting and small bug-fixing * Addressing comments and refactoring * Fix linting * rebasing * Addressing comments - 2 * Addressing comments -3 Change-Id: I207872757473210681d9db04bfdcd2c5e6deaa05 * Addressing comments - 4 Change-Id: I11f73c9b32e83c013cfb2224ccce06f60a128af7
* Add autoscheduler support to tvmc - Add an autoschedule module to tvmc - Extract common tuning option between autotuner and autoscheduler - Add testing * Linting and small bug-fixing * Addressing comments and refactoring * Fix linting * rebasing * Addressing comments - 2 * Addressing comments -3 Change-Id: I207872757473210681d9db04bfdcd2c5e6deaa05 * Addressing comments - 4 Change-Id: I11f73c9b32e83c013cfb2224ccce06f60a128af7
* Add autoscheduler support to tvmc - Add an autoschedule module to tvmc - Extract common tuning option between autotuner and autoscheduler - Add testing * Linting and small bug-fixing * Addressing comments and refactoring * Fix linting * rebasing * Addressing comments - 2 * Addressing comments -3 Change-Id: I207872757473210681d9db04bfdcd2c5e6deaa05 * Addressing comments - 4 Change-Id: I11f73c9b32e83c013cfb2224ccce06f60a128af7