Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Support deformable Conv2D NHWC #7075

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

comaniac
Copy link
Contributor

@comaniac comaniac commented Dec 10, 2020

PR #6999 added a TOPI compute for deformable Conv2D NHWC. This PR adds the required supports to lower NHWC deformable Conv2D from Relay so that it can be tuned by auto_scheduler.

Notes:

  • I didn't find a proper place to add unit tests. Please suggest the right place if we need them.
  • This is the first time I worked on infer type. Please help review to make sure I didn't make it wrong.

cc @icemelon9 @jroesch @merrymercy @vinx13 @Laurawly

Copy link
Member

@vinx13 vinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some test cases in tests/python/relay/test_op_level5.py

src/relay/op/nn/convolution.h Outdated Show resolved Hide resolved
@comaniac
Copy link
Contributor Author

there are some test cases in tests/python/relay/test_op_level5.py

Thanks for the pointer. Added 2 test cases to op level 5. I only added the infer type cases but not the execution because of the naive schedule on GPU.

Copy link
Contributor

@Laurawly Laurawly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laurawly Laurawly merged commit fcead9f into apache:main Dec 10, 2020
@Laurawly
Copy link
Contributor

Thanks @comaniac @vinx13 !

@comaniac comaniac deleted the layout_deformable_conv2d branch December 10, 2020 07:11
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
* [Relay] Support deformable conv2D NHWC

* add test case

* fix lint

* lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
* [Relay] Support deformable conv2D NHWC

* add test case

* fix lint

* lint
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
* [Relay] Support deformable conv2D NHWC

* add test case

* fix lint

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants