Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC] [ACL] include_non_call_ops = False #7121

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

d-smirnov
Copy link
Contributor

This PR allows ACL codegen to use AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.

This PR resolves issue https://discuss.tvm.apache.org/t/arm-compute-library-segv-with-inception-v1-squeezenet/7985/2

ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
@d-smirnov
Copy link
Contributor Author

d-smirnov commented Dec 17, 2020

cc @mbaret

@mbaret mbaret self-assigned this Dec 17, 2020
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm.

@mbaret
Copy link
Contributor

mbaret commented Dec 22, 2020

Thanks @d-smirnov

@mbaret mbaret merged commit bc43ed4 into apache:main Dec 22, 2020
masahi pushed a commit to masahi/tvm that referenced this pull request Dec 24, 2020
ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
ACL codegen now uses AnnotateTarget pass with include_non_call_ops = False
to prevent promoting non-call ops under the target of its arguments.
Squeezenet unit test added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants