Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoScheduler] Add custom build function #7185

Merged
merged 6 commits into from
Jan 5, 2021
Merged

[AutoScheduler] Add custom build function #7185

merged 6 commits into from
Jan 5, 2021

Conversation

leowang1225
Copy link
Contributor

Signed-off-by: leowang1225 810916296@qq.com

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@leowang1225
[AutoScheduler] Add custom build function
d02a266 
Signed-off-by: leowang1225 <810916296@qq.com>
@leowang1225
Copy link
Contributor Author

Signed-off-by: leowang1225 810916296@qq.com

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@merrymercy @FrozenGene please help to review!

FrozenGene
FrozenGene requested changes Dec 31, 2020
View reviewed changes
python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved
python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved
python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved
@leowang1225
[AutoScheduler] Add custom build function
9e66f14 
Signed-off-by: leowang1225 <810916296@qq.com>
jcf94
jcf94 reviewed Jan 4, 2021
View reviewed changes
python/tvm/auto_scheduler/measure.py
"""

def __init__(self, timeout=15, n_parallel=multiprocessing.cpu_count(), build_func="default"):
self.__init_handle_by_constructor__(_ffi_api.LocalBuilder, timeout, n_parallel, build_func)
if build_func == "default":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is designed to use the class static member?
Why not just use a self.build_func.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when auto_scheduler.local_builder.build is called, the context can't get LocalBuilder class instance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He should keep the state information of build_func between functions, so just self.build_func can not meet the requirement because we will create one class instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrozenGene @leowang1225
Since we pass the BuildFunc.name to the constructor, how about just register the custom build function by @tvm._ffi.register_func and pass the fuction name to it?
In this way, it can be serialized in args in the local_build_worker below.

jcf94
jcf94 requested changes Jan 4, 2021
View reviewed changes
python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved
@leowang1225
[AutoScheduler] Add custom build function
7346351 
Signed-off-by: leowang1225 <810916296@qq.com>
@FrozenGene
Copy link
Member

@jcf94 could you have another one round of review?

jcf94
jcf94 reviewed Jan 4, 2021
View reviewed changes
python/tvm/auto_scheduler/measure.py
"""

def __init__(self, timeout=15, n_parallel=multiprocessing.cpu_count(), build_func="default"):
self.__init_handle_by_constructor__(_ffi_api.LocalBuilder, timeout, n_parallel, build_func)
if build_func == "default":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrozenGene @leowang1225
Since we pass the BuildFunc.name to the constructor, how about just register the custom build function by @tvm._ffi.register_func and pass the fuction name to it?
In this way, it can be serialized in args in the local_build_worker below.

python/tvm/auto_scheduler/measure.py Show resolved Hide resolved
@jcf94
Copy link
Contributor

jcf94 commented Jan 4, 2021

@jcf94 could you have another one round of review?

Sorry for I'm a little busy this afternoon.

jcf94
jcf94 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I don't have any better suggestions.

@leowang1225
[AutoScheduler] Add custom build function
976caed 
Signed-off-by: leowang1225 <810916296@qq.com>
@FrozenGene FrozenGene merged commit 23bd825 into apache:main Jan 5, 2021
@FrozenGene
Copy link
Member

Thanks for the great work @leowang1225 and thanks for the reviewing @jcf94 , it is merged now.

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
@leowang1225 @tkonolige
[AutoScheduler] Add custom build function (apache#7185)
41ad92d 
* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
@leowang1225 @masahi
[AutoScheduler] Add custom build function (apache#7185)
cbd62b6 
* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
@leowang1225
[AutoScheduler] Add custom build function (apache#7185)
7fa9b24 
* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
@leowang1225 @trevor-m
[AutoScheduler] Add custom build function (apache#7185)
7e14da5 
* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@leowang1225 @electriclilies
[AutoScheduler] Add custom build function (apache#7185)
8f89b42 
* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <810916296@qq.com>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenGene FrozenGene FrozenGene approved these changes

@jcf94 jcf94 jcf94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leowang1225 @FrozenGene @jcf94