Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Fix issues for Clip and RoiAlign #7237

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[ONNX] Fix issues for Clip and RoiAlign #7237

merged 1 commit into from
Jan 12, 2021

Conversation

lixiaoquan
Copy link
Contributor

@lixiaoquan lixiaoquan commented Jan 9, 2021 •
edited
Loading

@mbrookhart @masahi Could you please take a look?

@masahi
Copy link
Member

masahi commented Jan 12, 2021

Maybe you can tell us what the issue was.

@lixiaoquan
Copy link
Contributor Author

lixiaoquan commented Jan 12, 2021 •
edited
Loading

Maybe you can tell us what the issue was.

For RoiAlign, 1) attr.get(“mode", "avg”) will return a string "avg" as default value, which always fails the following test if mode == b"avg" 2) infer_type(rois).type_annotation only works when rois is variable, but it could be CallNode

For Clip 1) It is possible "min"/"max" don't exist in attrs

@masahi masahi merged commit b84eb16 into apache:main Jan 12, 2021
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
@lixiaoquan @masahi
[ONNX] Fix issues for Clip and RoiAlign (apache#7237)
3c73e7c
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 18, 2021
@lixiaoquan @masahi
[ONNX] Fix issues for Clip and RoiAlign (apache#7237)
5b052cb
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
@lixiaoquan
[ONNX] Fix issues for Clip and RoiAlign (apache#7237)
a690479
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
@lixiaoquan @trevor-m
[ONNX] Fix issues for Clip and RoiAlign (apache#7237)
91b7630
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@lixiaoquan @electriclilies
[ONNX] Fix issues for Clip and RoiAlign (apache#7237)
9ab0e26
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees

@mbrookhart mbrookhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lixiaoquan @masahi @mbrookhart