Add op_name in error message for Pool #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More info in error messages is always good. LGTM |
jwfromm
approved these changes
Jan 12, 2021
|
@jwfromm Hi, could you help to merge this PR? Or anyone else is needed for approving review? |
ZihengJiang
approved these changes
Jan 12, 2021
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 14, 2021
* add op_name in error message for Pool * fix tiny issue for arguments * fix tiny issue for LpPool Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
* add op_name in error message for Pool * fix tiny issue for arguments * fix tiny issue for LpPool Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* add op_name in error message for Pool * fix tiny issue for arguments * fix tiny issue for LpPool Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* add op_name in error message for Pool * fix tiny issue for arguments * fix tiny issue for LpPool Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* add op_name in error message for Pool * fix tiny issue for arguments * fix tiny issue for LpPool Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version will not raise correct error since the op_name is not defined.
@jwfromm