-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][Topi][CPU] Dense with weight transform #7404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
reviewed
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
@icemelon9 PTAL |
icemelon
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kevinthesun |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* Add CPU dense weight transform * Fix format * Fix python format * Fix pylint * Minor fix * Add test * Do not need to infer layout for dense * Fix test * Rename dense_pack * Fix test * Fix lint * Fix dynamic shape dense * Fix lint * Fix autotvm task extraction test * Disable AlterOpLayout in micro_tflite.py tutorial
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Add CPU dense weight transform * Fix format * Fix python format * Fix pylint * Minor fix * Add test * Do not need to infer layout for dense * Fix test * Rename dense_pack * Fix test * Fix lint * Fix dynamic shape dense * Fix lint * Fix autotvm task extraction test * Disable AlterOpLayout in micro_tflite.py tutorial
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Add CPU dense weight transform * Fix format * Fix python format * Fix pylint * Minor fix * Add test * Do not need to infer layout for dense * Fix test * Rename dense_pack * Fix test * Fix lint * Fix dynamic shape dense * Fix lint * Fix autotvm task extraction test * Disable AlterOpLayout in micro_tflite.py tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds weight transformed dense to avoid weight layout conversion. With this PR, current dense pack template can achieve 2x performance on CPU targets.
@icemelon9