[RUNTIME] Fast path for single thread run to allow app level threading #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thanks @masahi , I think we should avoid set affinity when nthread ==1 , cc @yidawang @ZihengJiang @icemelon9 |
|
Perhaps another guard for the nthread == 1 case at this point? tvm/src/runtime/threading_backend.cc Line 85 in 18fdf41 Though it feels weird to be using a threadpool at all for the nthread == 1 case. Also, unrelated, but saw this while looking around this code: I'm probably just reading this wrong, but to me the below line looks odd: why is the tvm/src/runtime/thread_pool.cc Line 273 in 18fdf41 |
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Feb 22, 2021
apache#7454) * Fast path for single thread run to allow app level threading * add sync counter to avoid error in one of tests
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
apache#7454) * Fast path for single thread run to allow app level threading * add sync counter to avoid error in one of tests
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
apache#7454) * Fast path for single thread run to allow app level threading * add sync counter to avoid error in one of tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwfromm @tqchen
Seems using TVM's own thread pool doesn't allow running multiple independent instance of mods concurrently across different cores with
TVM_NUM_THREADS=1. All threads run on a single core for some reason.Need to figure out what
SetAffinityfunction is doingtvm/src/runtime/threading_backend.cc
Line 100 in 1831c17