Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] add ShapeFunc for one_hot op #7490

Merged
merged 3 commits into from
Mar 8, 2021
Merged

[Relay] add ShapeFunc for one_hot op #7490

merged 3 commits into from
Mar 8, 2021

Conversation

monklof
Copy link
Contributor

@monklof monklof commented Feb 22, 2021

No description provided.

@monklof
Copy link
Contributor Author

monklof commented Feb 22, 2021

@kevinthesun @zhiics

@tqchen
Copy link
Member

tqchen commented Mar 3, 2021

ping @icemelon9 @mbrookhart @zhiics would be great if you can help to take a look.

mbrookhart
mbrookhart requested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that executes one_hot with a dynamic input shape so we hit this code?

@mbrookhart
Copy link
Contributor

Otherwise LGTM

@tqchen tqchen added the status: need test case need test cases to cover the change label Mar 3, 2021
@monklof
Copy link
Contributor Author

monklof commented Mar 4, 2021

@mbrookhart okay

@monklof
Copy link
Contributor Author

monklof commented Mar 8, 2021

Hi @mbrookhart Unit tests have been added, it's this what you want?

icemelon
icemelon approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrookhart mbrookhart merged commit b827845 into apache:main Mar 8, 2021
@mbrookhart
Copy link
Contributor

Thanks @monklof @icemelon9 @tqchen

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@monklof
[Relay] add ShapeFunc for one_hot op (apache#7490)
14d6c17 
* [Relay] add ShapeFunc for one_hot op

* fix pylint

* add test for shapefunc of one_hot op
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@monklof @trevor-m
[Relay] add ShapeFunc for one_hot op (apache#7490)
0de423d 
* [Relay] add ShapeFunc for one_hot op

* fix pylint

* add test for shapefunc of one_hot op
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

@icemelon icemelon icemelon approved these changes

Assignees

@mbrookhart mbrookhart

Labels
status: need review status: need test case need test cases to cover the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monklof @tqchen @mbrookhart @icemelon