[RUNTIME] Move Map into runtime #7570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use Map to store parameters needed at runtime.
jroesch
reviewed
Mar 2, 2021
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| #include <tvm/arith/int_set.h> | |||
| #include <tvm/ir/expr.h> | |||
| #include <tvm/node/container.h> | |||
There was a problem hiding this comment.
@junrushao1994 can we remove the node subdirectory now? seems to be out-dated naming now that we are in object land?
There was a problem hiding this comment.
The node subdir still contains a lot of useful stuff, like structural hash and reflection, etc. Removing node/container.h looks good to me
jroesch
approved these changes
Mar 2, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [RUNTIME] Move Map into runtime
This allows us to use Map to store parameters needed at runtime.
* node.{Array|Map} -> runtime.{Array|Map}
* missed some renames
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* [RUNTIME] Move Map into runtime
This allows us to use Map to store parameters needed at runtime.
* node.{Array|Map} -> runtime.{Array|Map}
* missed some renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use Map to store parameters needed at runtime. Needed for #7559.
@junrushao1994