Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Set USE_LLVM OFF when build VTA on pynq board #7657

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[docs] Set USE_LLVM OFF when build VTA on pynq board #7657

merged 1 commit into from
Mar 15, 2021

Conversation

LeiWang1999
Copy link
Contributor

Refer to this commit : #6944

The Default value of USE_LLVM flag had been changed

set(USE_LLVM OFF)
set(USE_LLVM ON)

But the VTA build tutorial didn't follow it , FPGA board don't need compile llvm .

-- Build VTA runtime with target: pynq
CMake Error at cmake/utils/FindLLVM.cmake:47 (find_package):
  Could not find a package configuration file provided by "LLVM" with any of
  the following names:

    LLVMConfig.cmake
    llvm-config.cmake

  Add the installation prefix of "LLVM" to CMAKE_PREFIX_PATH or set
  "LLVM_DIR" to a directory containing one of the above files.  If "LLVM"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  cmake/modules/LLVM.cmake:31 (find_llvm)
  CMakeLists.txt:345 (include)

Please cc, @tqchen @areusch @tmoreau89

@tqchen
Copy link
Member

tqchen commented Mar 14, 2021

Thanks @LeiWang1999 for a great point. I think we should still go and turn off the USE_LLVM in cmake so we do not have to worry about so in runtime only build, can you update the patch to directly revert the USE_LLVM change in #6944

@LeiWang1999
Copy link
Contributor Author

Yeah, Absolutely.

@LeiWang1999 LeiWang1999 reopened this Mar 14, 2021
cmake/config.cmake Show resolved Hide resolved
@tqchen tqchen merged commit 1878889 into apache:main Mar 15, 2021
@tqchen
Copy link
Member

tqchen commented Mar 15, 2021

Thanks @LeiWang1999 !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Co-authored-by: Lei Wang <34334180+NjtechPrinceling@users.noreply.github.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
Co-authored-by: Lei Wang <34334180+NjtechPrinceling@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants