[Vulkan] Workaround for zero size allocation #7691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
reviewed
Mar 18, 2021
There was a problem hiding this comment.
Could you do this for OpenCL as well and I'll close #7672 ? I think this is better than returning nullptr
|
Thanks @masahi @tmoreau89 @mbrookhart ! |
AndrewZhaoLuo
pushed a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Mar 22, 2021
* main: [AutoScheduler] Add function name in message (apache#7703) [Vulkan] Workaround for zero size allocation (apache#7691) Change behavior of onnx importer to throw when user provides an input no in the graph. (apache#7699) Free TensorRT engine and context (apache#7702) [TFLite] Cast operator adapted for MLIR-based convertor (apache#7639) [CPP_RPC] allow user supplied work dir (apache#7670) Default value for graph_runtime Init lookup_linked_param_func (apache#7676)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we get segfault from Vulkan if a request to allocate 0 size is made. Returning nullptr in such case works for other backend, but VK seems to have issues. This workaround was confirmed to be effective.
Running NMS tests in
test_any.pyserves as the test case. Without this it would segfault.@tmoreau89 @mbrookhart @tqchen