[crt] fix shift out of type bounds #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with "-fsanitize=undefined" I got the following error:
tvm/src/runtime/crt/common/crt_runtime_api.c:213:32: runtime error: left shift of 32770 by 16 places cannot be represented in type 'int'
The expression "module_index | 0x8000" is of type "int" and needs to be casted to unsigned before the shift.
|
thanks @rafzi, this change looks good to me. can you retrigger the CI by adding an empty commit? looks like it got stuck on task_rust. |
tqchen
approved these changes
Mar 31, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [crt] fix shift out of type bounds
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [crt] fix shift out of type bounds
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [crt] fix shift out of type bounds
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* [crt] fix shift out of type bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with "-fsanitize=undefined" I got the following error:
The expression "module_index | 0x8000" is of type "int" and needs to be casted to unsigned before the shift.
@areusch